Open karthiksriramuoa opened 6 years ago
@karthiksriramuoa Approved
In fact, after I merged the current upstream repository into my fork, I cannot login, either. I tried to input a wrong password, and the application demonstrated an error message: "Error: Bad credentials". So I think the sign in function is working, but there are some issues with the login process.
Also, I have an copy of the original zip file of VisualGit as backup. I unzipped and installed it and tried to login in that version, and I succeed.
Maybe the content of the issue should be modified. Some issues appeared after students send PRs. @softeng-701 @karthiksriramuoa
@karthiksriramuoa @ls-morning Yes, I think this is a general problem with signing in no matter how you get the code. This issue should look at signing in in general
@softeng-701 @ls-morning I reported the sign in issue and an issue with starting the application, to Kelly, but she replied me that it was a problem with the npm version. I am not sure if its because of the same.
@karthiksriramuoa Did you get it working by changing the version?
@softeng-701 No. Changing the version didnt work. So i thought there was an issue with my machine. I hence worked on a cloned repository shared by my teammate.
Expected Behavior -
Actual Behavior -
Proposed Solution - -Investigate the authenticate module and check what happens when clicked on Sign In. -Resolve the issue by authenticating and validating the user against Github credentials.