search

kblincoe / VisualGit_SE701_3

0 stars 0 forks source link

GitHub profile pictures on nodes #27

Open kblincoe opened 6 years ago

kblincoe commented 6 years ago

Currently, only the first letter of GitHub users' names appears on the nodes. It would be more useful to have their GitHub profile pictures so they can be more easily identified.

kathrynjaggar commented 6 years ago

Claiming this issue for @tagumi

shoebilldev commented 6 years ago

@softeng-701 can this be upgraded to a large please. Usernames are not stored in commits, only the user's full name and email are, so username has to be retrieved by the user's name through the github api. Also requires storage and handling of local pictures retrieved by github.

shoebilldev commented 6 years ago

The nodegit commit class does not store username, it only stores full name and email.

The only way we could think to overcome this is to search github's API for the full name get the username from the first result, as even searching by email does not work (as not everyone has emails public, and not everyone only has one account with each email).

I am going to create an issue to show that it is blocking this, as i'm sure the same it is blocking other issues too that people can reference.

shoebilldev commented 6 years ago

This issue is blocked by #122

Unclaimed @softeng-701