search

kblincoe / VisualGit_SE701_3

0 stars 0 forks source link

Created three scripts one bash and two batch for ubuntu and mac #58

Closed shoebilldev closed 6 years ago

shoebilldev commented 6 years ago

run.desktop runs the "npm start" command on ubuntu machines and will show up as a Visual Git executable

run-bash-mac.command runs the "npm start" command on mac machines

run-batch.bat runs the "npm start" command in the windows cmd

The user may need to run once "chmod u+x run-bash.sh" on ubuntu or "chmod +x run-bash-mac.command" on mac or run the "run-batch.bat" as admin depending on user privileges

closes issue #12

softeng-701 commented 6 years ago

@tagumi changes have been requested

softeng-701 commented 6 years ago

@tagumi Please look at the requested changes and squash your commits

shoebilldev commented 6 years ago

Changes have been made as per request

shoebilldev commented 6 years ago

@softeng-701 ok to merge pr and close issue #58 ?

softeng-701 commented 6 years ago

@tagumi You must squash your commits locally first, do you know how to do this?

shoebilldev commented 6 years ago

@softeng-701 yes, though I was just going to merge with this option:

image

will squash locally first though

softeng-701 commented 6 years ago

@tagumi Please don't merge your own PR, it is against the specified workflow for this assignment. We would like squashes to be done locally so you get experience with the rebase command, thanks!

shoebilldev commented 6 years ago

Closed and Deleted due to rebasing issues, created new branch with changes and pull request for them.

Lessons were learned.