search

kblincoe / VisualGit_SE701_3

0 stars 0 forks source link

Display github account name #66

Closed Long315 closed 6 years ago

Long315 commented 6 years ago

On the main screen, the gitHubName will be displayed on the right top of the screen, just next to 'log out' button.

softeng-701 commented 6 years ago

@Long315 Please squash you commits and resolve merge conflicts. What is the number of the issue this resolves?

Long315 commented 6 years ago

The conflicts have been resolved. Ready to merge now. Issue 8: Display GitHub account name #8 @softeng-701

Long315 commented 6 years ago

Oh, it seems that I made a mistake. I just want to squash my commits, but I clicked the "squash and merge" button by mistake.....Sorry to do your job @softeng-701, need I create a new pull request to revert these changes?

softeng-701 commented 6 years ago

@Long315 yes, its against the workflow for this assignment to merge your own PR. I've made a PR to revert: https://github.com/kblincoe/VisualGit_SE701_3/pull/84 Please can you do the official review on the revert and then resubmit your PR. Thanks