search

kboghdady / youTube_ads_4_pi-hole

YouTube script to add the new Ads list for Pi-hole
2.43k stars 266 forks source link

16 Domains invalid! #132

Closed 0xMakrem closed 1 year ago

0xMakrem commented 1 year ago

Hi,

I think the idea of the script is great, but after using it I tested the initial list manually with the command pihole -g and here is the result:

[i] Target: https://github.com/kboghdady/youTube_ads_4_pi-hole/blob/master/black.list [✓] Status: Retrieval successful [i] Analyzed 16 domains, 16 domains invalid! Sample of invalid domains:

  • content="github.com">
  • content="github.com">
  • data-target="input-demux.source"
  • data-targets="input-demux.sinks"
  • cache-key="v0:1594848934.0"

Is the problem in the list writing synthesis?

0xMakrem commented 1 year ago

The problem was solved by reading the documentation.

Correction if someone fell into the same confusion:

@ALL: I think the file name should be changed because it's may misleading and also because we should stop saying "blacklist"