search

kboghdady / youTube_ads_4_pi-hole

YouTube script to add the new Ads list for Pi-hole
2.45k stars 266 forks source link

Doesn't block ads #68

Open ImDini opened 4 years ago

ImDini commented 4 years ago

After adding it correctly, there is still tons of ads that slip through. Wasn't this list supposed to be updated? I get some ads will come through but it's all..

kboghdady commented 4 years ago

I just updated some of the ignore list. I have very few ads which come from a DNS that does redirection to the actual video. Please try it with the new ignore list

ImDini commented 4 years ago

I just updated some of the ignore list. I have very few ads which come from a DNS that does redirection to the actual video. Please try it with the new ignore list

Where do we put the ignore list?

bktiger86 commented 4 years ago

I am having the same issue. In the US. When I add the two adlist it blocks everything including the original YouTube video. Any idea why?

91ajames commented 4 years ago

@bktiger86 after further investigating, I saw this report. Be more helpful if the moder tell users in the readme there are 2 ways to do this which to me found it confusing at first for videos not working when both are enabled. which i hit a few ad videos playing under private chrome for a test while i use firefox the most. https://github.com/kboghdady/youTube_ads_4_pi-hole/issues/72

AdnanHodzic commented 4 years ago

For me not only does this script not block ads, but it also causes infinite loading loops on Youtube.

bondskin commented 4 years ago

For me not only does this script not block ads, but it also causes infinite loading loops on Youtube.

same with me

phelix001 commented 3 years ago

Fresh clone and getting this error: /home/pi/youTube_ads_4_pi-hole/youtube.sh: 44: /home/pi/youTube_ads_4_pi-hole/youtube.sh: cannot open ignore.list: No such file

Had to rename ignore.list to ignore.list.bak to get it to work.....I'm guessing it's not ignoring anything now.

kboghdady commented 3 years ago

@phelix001 you need to change the repoDir ## line # 13 This need to be changed to your actual repo dir on your machine repoDir='/pi/youTube_ads_4_pi-hole'

phelix001 commented 3 years ago

Yes, I did that.... repoDir='/home/pi/youTube_ads_4_pi-hole'

Darkepi commented 2 years ago

@kboghdady I have checked and my repoDir is correct repoDir='/home/pi/youTube_ads_4_pi-hole' but I am still receiving the error "/home/pi/youTube_ads_4_pi-hole/youtube.sh: 47: cannot open ignore.list: No such file".

Could you help me?