kboghdady / youTube_ads_4_pi-hole

YouTube script to add the new Ads list for Pi-hole
2.45k stars 266 forks source link

Argument list to long #97

Open Joly0 opened 3 years ago

Joly0 commented 3 years ago

Running the script gives the error "Argument list to long" and exits. The same error is found here #50 and as i downloaded the script today, the fix is implemented, but it still gives me the error.

Armag3ddon commented 3 years ago

I get the same error, in line 57: ./youtube.sh: 57: ./youtube.sh: curl: Argument list too long

Armag3ddon commented 3 years ago

Trying to be helpful here: I installed the script today. My PiHole has been running for quite some time by now (months). I don't know what this script is trying to achieve but sharedlogs is massive. For a test run, I redirected the output to bash and it filled my entire buffer. I don't knw if this is working as intended.

faxesystem commented 3 years ago

I simply disabled the last two lines since the creation of the logs, that are uploaded to the author, seem to cause this problem. It even tells you to do that if you want. :)

Armag3ddon commented 3 years ago

I simply disabled the last two lines since the creation of the logs, that are uploaded to the author, seem to cause this problem. It even tells you to do that if you want. :)

Yes, you can do that but it completely defeats the purpose of sharing the blocked URLs so everyone can benefit from it.

sonnyb9 commented 2 years ago

Disabling the last 2 lines stops the crowd sourced list of *googlevideo.com URLs, but if it doesn’t work anyway it’s the same result. I didn’t see anything the looks like a fix for this. Without a real fix, it’s self defeating.

ohare93 commented 1 year ago

Agreed, this should be fixed for all to benefit