search

kbot7 / NgrokAspNetCore

Integration of Ngrok with the AspNetCore pipeline. Tools to automatically create ngrok tunnels on application startup
MIT License
25 stars 10 forks source link

Fixed null addresses #19

Closed kbot7 closed 4 years ago

kbot7 commented 4 years ago

I resolved the null address issue by waiting for IApplicationLifetime.ApplicationStarted to fire. This seems to be the right hook to guarantee IServerAddressesFeature is populated.

I copied your master branch to fs-master on the original repo. Once you review this PR, I'm comfortable merging fs-master to develop. From there we can both work out of develop until we're ready to push out the next official NuGet release.

I already have another branch, fs-master-rename, with the renaming already complete. Once we've merged this PR, we can merge #21, then lastly we can merge to develop via #20.

Merge order: resolved-null (#19) -> fs-master-rename (#21) -> fs-master (#20) -> develop

Thanks again for the improvements! I enjoy the UI updates you've made, as well as the IHostedService implementation. Let me know if you have any other improvements in mind. Since you are now a maintainer, let's plan to have us review eachother's PRs.

kbot7 commented 4 years ago

I ended up getting everything working together. I've merged all the PRs describe above to the develop branch.

Note I reverted back to the original name and directories. I don't feel strongly about this, I merely wanted to compare the branches easier. If you have opinions on directory structure, feel free to submit changes for that.