search

kboyd / Roc

Everything ROC and Precision-Recall curves.
BSD 2-Clause "Simplified" License
23 stars 7 forks source link

Checking for empty inputs, better names #28

Closed afbarnard closed 10 years ago

afbarnard commented 10 years ago

These are changes to help the user-friendliness of the library and the API. I kept mistakenly trying to construct a curve from empty input (due to an empty---failed---join) and getting out nonsense without any warning or error. After fixing that I got carried away with being fed up with my poor choice of names in 'predicteds' and 'actuals' so I fixed that as well. And a few other things along the way. These are relatively benign changes and I would like to quickly merge them into master so I can merge them into the branch for the main program. @kboyd, what do you think? Any objections?

kboyd commented 10 years ago

The naming changes sound good to me. Do you want to merge this to master before the main program? Or just merge into the main branch and then bring everything to master at once?