kbr-net / sdrive-max

Arduino based Atari 8-bit Floppy Emulator with Touchscreen
http://www.kbrnet.de/projekte/sdrive-max/index.html
GNU General Public License v3.0
94 stars 22 forks source link

ILI9325 suport added (willy). SCROLL is not supported by this chip. #23

Closed willyvmm closed 4 years ago

willyvmm commented 4 years ago

I will try to look into the code maybe today evening.

śr., 29.01.2020, 15:54 użytkownik kbr-net notifications@github.com napisał:

@kbr-net commented on this pull request.

In display.c https://github.com/kbr-net/sdrive-max/pull/23#discussion_r372429709:

@@ -42,6 +42,211 @@ void TFT_init() TFT_write_cmd(0x28); //gate output and display on TFT_write(0x3c); //TFT_write_cmd(0x22); //GRAM +#elif defined ILI9325 +

  • // set SRAM internal timing
  • TFT_write_cmd(0x00E5);

I made a test merge with the actual v12c branch:

Program: 32302 bytes (98.6% Full) (.text + .data + .bootloader)

There are 46 bytes too much, only 32256 are available!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kbr-net/sdrive-max/pull/23?email_source=notifications&email_token=AF3ELHTI5UFFGA7BNAJZZILRAGKD3A5CNFSM4I6XIVP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCTPSFJA#discussion_r372429709, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3ELHS3MLZKRX7K36XO2KDRAGKD3ANCNFSM4I6XIVPQ .

willyvmm commented 4 years ago

It's an old chip and needs very long initiation procedure. New chips are much easier.

śr., 29.01.2020, 16:39 użytkownik kbr-net notifications@github.com napisał:

@kbr-net commented on this pull request.

In display.c https://github.com/kbr-net/sdrive-max/pull/23#discussion_r372459346:

@@ -42,6 +42,211 @@ void TFT_init() TFT_write_cmd(0x28); //gate output and display on TFT_write(0x3c); //TFT_write_cmd(0x22); //GRAM +#elif defined ILI9325 +

  • // set SRAM internal timing
  • TFT_write_cmd(0x00E5);

Could reduce to:

Program: 31750 bytes (96.9% Full)

See: 3359ec5 https://github.com/kbr-net/sdrive-max/commit/3359ec591535a7b02d4601ce8f9acf9324f22adc

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kbr-net/sdrive-max/pull/23?email_source=notifications&email_token=AF3ELHSZX6HWPRLY3ZQHY73RAGPM5A5CNFSM4I6XIVP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCTP3LIQ#discussion_r372459346, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3ELHR4W2XSAQE24GPVSXLRAGPM5ANCNFSM4I6XIVPQ .

kbr-net commented 4 years ago

Could you test my changes in this branch, and give me feedback?

willyvmm commented 4 years ago

I don't have a physical atari available right now, but I can test all other functions tonight.

czw., 30.01.2020, 09:15 użytkownik kbr-net notifications@github.com napisał:

Could you test my changes in this branch https://github.com/kbr-net/sdrive-max/tree/willyvmm-master, and give me feedback?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kbr-net/sdrive-max/pull/23?email_source=notifications&email_token=AF3ELHXBXVIYF4YN2YMU45TRAKEB5A5CNFSM4I6XIVP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKKCOEI#issuecomment-580134673, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3ELHT4ALLJIDLJXSZAQELRAKEB5ANCNFSM4I6XIVPQ .

kbr-net commented 4 years ago

Display and touchscreen working is enough!

willyvmm commented 4 years ago

So once again.

The autodetection is not working properly with the ili9325 (check picture attached to previous email)

The change inside Makefile is to suppress error when running 'make clean' on already cleaned repo:

to repeat, just run 'make clean' twice

or check this log:

https://pastebin.com/HuzNdKUP

last line: make: *** [clean] Error 2

pt., 31 sty 2020 o 21:51 kbr-net notifications@github.com napisał(a):

@kbr-net commented on this pull request.

no more needed, because touchscreen is now autodetected! Please use branch v12c as reference, the old v12 will be deleted soon, or wait, if i have merged it to master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kbr-net/sdrive-max/pull/23?email_source=notifications&email_token=AF3ELHWRTIUSIKYUYGSU6G3RASFNVA5CNFSM4I6XIVP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCT3ZKXA#pullrequestreview-351769948, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3ELHVAKGROM52DJC5DQ7TRASFNVANCNFSM4I6XIVPQ .

-- http://PoloniaInfo.dk - największy portal polonijny w Danii.

willyvmm commented 4 years ago

And YES i've used branch v12c !

pt., 31 sty 2020 o 21:59 willyvmm . willyvmm@gmail.com napisał(a):

So once again.

The autodetection is not working properly with the ili9325 (check picture attached to previous email)

The change inside Makefile is to suppress error when running 'make clean' on already cleaned repo:

to repeat, just run 'make clean' twice

or check this log:

https://pastebin.com/HuzNdKUP

last line: make: *** [clean] Error 2

pt., 31 sty 2020 o 21:51 kbr-net notifications@github.com napisał(a):

@kbr-net commented on this pull request.

no more needed, because touchscreen is now autodetected! Please use branch v12c as reference, the old v12 will be deleted soon, or wait, if i have merged it to master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kbr-net/sdrive-max/pull/23?email_source=notifications&email_token=AF3ELHWRTIUSIKYUYGSU6G3RASFNVA5CNFSM4I6XIVP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCT3ZKXA#pullrequestreview-351769948, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3ELHVAKGROM52DJC5DQ7TRASFNVANCNFSM4I6XIVPQ .

-- http://PoloniaInfo.dk - największy portal polonijny w Danii.

-- http://PoloniaInfo.dk - największy portal polonijny w Danii.

kbr-net commented 4 years ago

Ok, i had an evil bug in v12c, i will push a fix soon, but display is working correctly?

willyvmm commented 4 years ago

That was not possible to calibrate touch, but ee writer and calibration screen was OK.

sob., 1.02.2020, 08:12 użytkownik kbr-net notifications@github.com napisał:

Ok, i had an evil bug in v12c, i will push a fix soon, but display is working correctly?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kbr-net/sdrive-max/pull/23?email_source=notifications&email_token=AF3ELHRLKSPZZ462NEFXDYTRAUOHLA5CNFSM4I6XIVP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKQWL7I#issuecomment-581002749, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3ELHRU5QPBULZB7LNODSTRAUOHLANCNFSM4I6XIVPQ .

kbr-net commented 4 years ago

manually merged in v12c