search

kbr / fritzconnection

Python-Tool to communicate with the AVM Fritz!Box by the TR-064 protocol and the AHA-HTTP-Interface
MIT License
303 stars 59 forks source link

[Draft] Strict typing #106

Closed chemelli74 closed 2 years ago

chemelli74 commented 2 years ago

This PR aim to get strict typing for the library

kbr commented 2 years ago

I have to admit that I'm not a fan of type hints. It makes the code look ugly and doesn't help very much – at least as you are not at Dropbox porting millions of lines from Python 2 to 3. Can help on larger projects, but fritzconnection isn't a large project. Also type errors are a very minor issue, if any. So I like to postpone this idea.

chemelli74 commented 2 years ago

Fine for me; take only care that every day one more HA core integration is strictly typed. For now HA allows any return type, but sooner or later it will be required to strict typing libraries.

Simone

chemelli74 commented 2 years ago

If you are not considering this proposal, please go ahead and close the PR.

Thank you,

Simone

kbr commented 2 years ago

Strict typing not enforced as time of writing.