search

kbr / fritzconnection

Python-Tool to communicate with the AVM Fritz!Box by the TR-064 protocol and the AHA-HTTP-Interface
MIT License
303 stars 59 forks source link

Fix requirements #113

Closed chemelli74 closed 2 years ago

chemelli74 commented 2 years ago

Simone

kbr commented 2 years ago

Why do you want to change this?

chemelli74 commented 2 years ago

Why do you want to change this?

I may be wrong, but I didn't change anything just removed a urllib3 explicit dependency that is no more needed and added missing requests to requirements.txt.

Simone

kbr commented 2 years ago

Ah, ok. A normal user just calls pip install fritzconnection. In this case requests will get installed as a dependency as given in setup. As a developer one would download the code and execute pip install . -e to get an editable installation (including requests). Additionally a developer should run pip install -r requirements.txt for adding the libraries for testing.

The urllib3 is a sub-dependency from requests. As long as there is no certificate verification implemented it is used to suppress the warnings on using tls-connection to the box. That's an implementation detail – try it out.

chemelli74 commented 2 years ago

I just added requests to requirements then. Will help once you accept #103 ;-)

Simone

chemelli74 commented 2 years ago

Add this to #103, doesn't make sense as stand-alone task.

Simone