kbr / fritzconnection

Python-Tool to communicate with the AVM Fritz!Box by the TR-064 protocol and the AHA-HTTP-Interface
MIT License
303 stars 59 forks source link

Devices in Guest WiFi stay connected #124

Closed Chreece closed 2 years ago

Chreece commented 2 years ago

As mentioned here: https://github.com/home-assistant/core/issues/54796

Any device connected to the Guest WiFi keep shown as connected even if they aren't...

kbr commented 2 years ago

That's to unspecific to dive into the code. Anyway fritzconnection just hands over what the router reports. May be you should file it to AVM.

Chreece commented 2 years ago

I have just contacted them, with links on the issues. Did you read the last post from @chemelli74 ?

kbr commented 2 years ago

Don't know. There are a couple of posts from all of us.

Chreece commented 2 years ago

I mean this post -> https://github.com/home-assistant/core/issues/54796#issuecomment-928082391

Sorry to disturb you. You seem having bad days :(

Grüße aus Köln

kbr commented 2 years ago

Ah, that's the post you mean. But it is as mentioned before: the library does not buffer or change results from the router. So the guest network seems to get handled in a different way by the router, for whatever reason. And yes, I've had a couple of busy days, but no bad days in the nice town of Düsseldorf ... :)

Chreece commented 2 years ago

So I have an answer from the support team from FRITZ!Tools:

wir haben den Fall mit je einer FRITZ!Box 7590/7590 AX noch einmal nachgestellt. Dabei wurde das LAN-Device nach <3 Sekunden auf "Active = 0" gesetzt. Ihre Beobachtung können wir auf Basis der bekannten Details bisher nicht bestätigen. Unsere Empfehlung wäre daher, den Wert "Active" zu monitoren oder alternativ aus WLANConfiguration "GetGenericAssociatedDeviceInfo" zu nutzen. Weitere Aspekte könnten wir ggf. nach Betrachtung der Supportdaten herausarbeiten.

Is that helpful?

kbr commented 2 years ago

That still needs further investigation: @chemelli74 mentioned that get_hosts_info method treats the "normal" WiFi and the guest network differently. As in both cases the same code gets executed I supposed that there must be something with the router. But the answer you got from the vendor was that they have been unable to reproduce this behaviour and suggests to take the "GetGenericAssociatedDeviceInfo" results. What is exactly what happens in the get_hosts_info method. So it could be helpful to know what you reported and where (and how) the "Active" state of devices gets traced in the HA code.

Chreece commented 2 years ago

I have just reported that the Devices in the Guest Network don't go offline long after they are disconnected, and pointed to this issue and the one by home assistant: https://github.com/home-assistant/core/issues/54796 including the findings from @chemelli74 . If you need to contact them (I'm sure you can explain better what the problem is) the email address that I got is:

Entwicklungssupport@avm.de

They seem to care about the problem, so I think we can find a solution if everyone cooperates

kbr commented 2 years ago

Tested it with a FRITZ!Box 7590 and FRITZ!OS: 7.28. Like AVM the device deactivates in less than 3 seconds. As well the "main" WiFi as the Guest Network.

To check the state I've used the get_hosts_info method from a FritzWLAN instance which in turn calls the "GetGenericAssociatedDeviceInfo" action from the "WLANConfiguration" service (as suggested by AVM). All networks are treated the same.

So with the given informations I'm also unable to reproduce the issue.

Chreece commented 2 years ago

I'm on FRITZ!Box 6591 and 7.27 This problem I had also with previous versions... I have send some logs to the guys from FRITZ!Tools

You don't use the FRITZ!Box Tools addon from HomeAssistant or do you?

I think the only one that could shine some light is @chemelli74

Anyway thank you sooo much for your time spending on the issue regardless your busy days :)

kbr commented 2 years ago

Currently I don't use HomeAssistant – therefore no experience with the FRITZ!Box Tools addon. So I like to close this. Please feel free to reopen in case of need.