search

kbr / fritzconnection

Python-Tool to communicate with the AVM Fritz!Box by the TR-064 protocol and the AHA-HTTP-Interface
MIT License
303 stars 59 forks source link

new library module fritztam #140

Open nejewoge opened 2 years ago

nejewoge commented 2 years ago

library module to interact with integrated telephone answering machine (TAM)

Hey. I really like your python module and I added some basic support for the telephone answering machine, as I needed that.

If you are interested in adding this to the lib-directory, here is a pull request.

The module is documented in library.rst, so I refer to that file for details.

This is actually my first pull request ever, so if I did something wrong let me know an I will try to fix it.

Of course if you have any questions, I am happy to answer them.

kbr commented 2 years ago

Thank you for the pull request. I will come to a code review and testing when I find some time for that. So please be patient.

nejewoge commented 2 years ago

Thank you. Take you time. I am happy to answer any questions you might have.

kbr commented 1 year ago

Hi, in case you are still interested, I've started with a first code review, but need some more time for a more detailed read. Thanks for your contribution.

nejewoge commented 1 year ago

Hi. Yes I am still interested. Thank you.

I will have a look an address your comments. I have just been a bit busy recently.

Paddy0174 commented 4 weeks ago

Just stumbled in here, coming from Home Assistant and would love to see this implemented as fritzconnection is the underlying library used in HA. :)

Can I do something to resolve this, and if so, what specifically or should I make a new PR to get this implemented?

Thanks!

nejewoge commented 4 weeks ago

Hey. I must say I lost interest in this. The original project, for which I wanted to use this, did not work out. (And then I had some git-struggles which prevented me from resolving the comments above.) Sorry for that.

So @Paddy0174, feel free to make an new PR. I am happy that this seems to useful for somebody.

nielsnl68 commented 3 weeks ago

I like this.