search

kbr / fritzconnection

Python-Tool to communicate with the AVM Fritz!Box by the TR-064 protocol and the AHA-HTTP-Interface
MIT License
303 stars 59 forks source link

Support Fritz Backed up Wake on LAN via CLI #148

Open samba2 opened 2 years ago

samba2 commented 2 years ago

WOL only works on layer 2. In a mixed fixed/ wireless LAN environment, there can be situations where e.g. your home NAS is attached to the LAN port and in case you need it, you want to wake it up from your wifi connected notebook.

Fritz TR-064 exposes this feature and it would be handy to have it also available at the CLI.

samba2 commented 2 years ago

addressed by https://github.com/kbr/fritzconnection/pull/149

mib1185 commented 2 years ago

addressed by #150

i guess you mean #149 😉

samba2 commented 2 years ago

addressed by #150

i guess you mean #149 😉

Yes, just found out about my mess - sorry for the confusion.

kbr commented 1 year ago

Made some initial comments to the pull request.

samba2 commented 1 year ago

@kbr tnx for the input and the suggestions. Will try to respond during the next days.

chrisbraucker commented 9 months ago

Hi! I saw that the related PR has been open for about a year now, with no further input from the original author. I just implemented the WOL API method in my fork in fritzhosts.py before I saw this issue/PR, in order to add it to the library interface. I would like to see this feature and optionally the CLI addition through to get merged.

@kbr I don't want to trespass on @samba2's prior work without their permission but would like to offer my help, do you have a suggestion on how to continue working on this? I'd be up to refactor the CLI code according to your requests, or can write my own implementation instead.

samba2 commented 9 months ago

@chrisbraucker tnx for picking up on that. Feel free to improve/ alter/ copy/ bin my suggested changes

kbr commented 9 months ago

@chrisbraucker In the next couple of weeks I'm short in time to go into this. But it seems you got confirmation from @samba2 to go ahead. I appreciate this kind of friendly communication very much and hope to join again as soon as possible.