[INFO] Requests pinning

[chemelli74]

Hi Klaus,

I noticed that in 1.10.2 you pinned requests to previous 2.28.0 release.

This is for compatibility with some old python ? Could you consider not pinning ? As this will cause conflicts with all libraries that are up-to-date.

Thank you,

Simone

[kbr]

It's pinned because of dependencies. segno is uncritical because it supports Python even back to 3.5 and 2.7, but requests has dropped Python 3.6 support with version 2.28.0. I suppose that is just because 3.6 is EOL. Seems to be, that fritzconnection has to adopt the requests way to support older Python versions – even if I dislike this a little bit: there are good reasons to leave 2.7 behind, but not 3.6. So to make fritzconnection a reliable distribution, the pinning has to be done.

Seems to turn out, that 1.10.2 is the last version supporting 3.6.

Idea could be to release a 1.10.3 version dropping 3.6. But that's surprising for bugfix versions. On the other hand releasing 1.11 with no other changes than dropping 3.6 support would also be a bit unusual. But I think, that's the way to go.

[chemelli74]

Cannot wait for 1.11 release then ;-)

Simone

[cdce8p]

It actually isn't necessary to add an upper limit. Since requests bumped python_requires to >=3.7. Pip won't ever install 2.28.0 for Python 3.6 and instead fall back to 2.27.x. https://github.com/psf/requests/blob/v2.28.0/setup.py#L97

Even with the upper limit removed, 3.6 can thus still be supported. You'll only need to drop it when you start to add new language features.

[kbr]

Thanks, learned something new about pip dependency checking not known in this detail before. Will provide a 1.10.3 bug-release rolling back the pinning for upper limits.

[kbr]

1.10.3 is out.

[cdce8p]

1.10.3 is out.

Thanks!