Fix FritzHost.get_hosts_attributes() - Githubissues

kbr / fritzconnection

Python-Tool to communicate with the AVM Fritz!Box by the TR-064 protocol and the AHA-HTTP-Interface

MIT License

303 stars 59 forks source link

Fix FritzHost.get_hosts_attributes() #190

Closed mib1185 closed 11 months ago

mib1185 commented 12 months ago

Hi @kbr

this will fix two issues with the get_hosts_attributes

1. url incomplete

https://github.com/kbr/fritzconnection/blob/790b5872b3cabb2a65dca9175a9e22819215183f/fritzconnection/lib/fritzhosts.py#L206-L207

NewX_AVM-DE_HostListPath does only contain the path, but not the full url

2. arguments given to `get_xml_root`

https://github.com/kbr/fritzconnection/blob/790b5872b3cabb2a65dca9175a9e22819215183f/fritzconnection/lib/fritzhosts.py#L208

def get_xml_root(source, timeout=None, session=None) takes one positional and two optional arguments

I guess this is caused by the "different implementation" stated in https://github.com/kbr/fritzconnection/issues/134#issuecomment-1200162131 🤔

cc @chemelli74

kbr commented 11 months ago

Wow, I'm wondering how this bug made it originally into the 1.10 release. Thanks. Will release 1.12.1 in the next days.