kbr / fritzconnection

Python-Tool to communicate with the AVM Fritz!Box by the TR-064 protocol and the AHA-HTTP-Interface
MIT License
304 stars 59 forks source link

fritzcallforwarding #32

Open jmtatsch opened 4 years ago

jmtatsch commented 4 years ago

Hi Klaus,

was the fritzcallforwarding module i contributed somehow removed on purpose or did it get lost in the translation somewhere?

kbr commented 4 years ago

Hi Julian,

not all library modules have been translated at the first attempt. Especial fritzcallforwarding needs some work (like fritzphonebook), because the lxml-dependency has been removed (making it much more easier to install fritzconnection on some platforms). So your module is not forgotten and will come back. Thank you very much for the contribution of fritzcallforwarding.

jmtatsch commented 4 years ago

Hi Klaus,

that is great to hear. Maybe I can help. So it is just the lxml that needs to be replaced or other stuff as well?

kbr commented 4 years ago

Hi Julian,

if you have some spare time and like to help out, that would be very appreciated. Rewriting fritzcallforwarding is a bit challenging because there is an action_call that returns a url to retrieve the real data as xml. Parsing the xml data can be done by using the new @processor class-decorator from fritzconnection.core.processor. That's also the preferred way to do it. The module fritzphonebook can be used as an example. If you have any questions, please don't hesitate to ask.