search

kbr / fritzconnection

Python-Tool to communicate with the AVM Fritz!Box by the TR-064 protocol and the AHA-HTTP-Interface
MIT License
304 stars 59 forks source link

Update lxml to at least version 4.3.5 for 0.8.X to allow fritzcollectd under Ubuntu Focal #46

Closed SuperSandro2000 closed 4 years ago

SuperSandro2000 commented 4 years ago

lxml is not buildable under Ubuntu Focal and fritzcollectd still depends on pre 1.0.0 fritzconnection. Could you release a version 0.8.5 which has no strict dependency on 4.3.4 but instead on 4.3.5? This would probably fix fritzcollectd under Ubuntu Focal/20.04 without any major reworks on either sides.

jobenvil commented 4 years ago

Could you release a version 0.8.5 which has no strict dependency on 4.3.4 but instead on 4.3.5? This would probably fix fritzcollectd under Ubuntu Focal/20.04 without any major reworks on either sides.

Definitely the best approach.

kbr commented 4 years ago

As I do not plan to maintain 0.8.x any longer, changing the requirements, including some basic testing of the 0.8.x version with Python 2.7, just took a couple of minutes – so here its is: version 0.8.5

The lxml-dependency has been updated from 4.3.4 to the most recent 4.5.1 version. It's fixed again to this version to prevent breaking changes in case lxml drops Python 2.7 support in future releases.

jobenvil commented 4 years ago

For the record:

root@locky:~# pip3 install fritzcollectd --upgrade
Processing ./.cache/pip/wheels/f5/26/fa/e1fe00aeb58656b3dcbb2b11d5ba20193ddf8261be94850976/fritzcollectd-0.7.0-py3-none-any.whl
Requirement already satisfied, skipping upgrade: pbr in /usr/local/lib/python3.8/dist-packages (from fritzcollectd) (5.4.5)
Collecting fritzconnection<1.0.0,>=0.8.0
  Downloading fritzconnection-0.8.5-py3-none-any.whl (72 kB)
     |████████████████████████████████| 72 kB 231 kB/s
Collecting lxml==4.5.1
  Downloading lxml-4.5.1.tar.gz (4.5 MB)
     |████████████████████████████████| 4.5 MB 6.6 MB/s
Requirement already satisfied, skipping upgrade: requests==2.22.0 in /usr/lib/python3/dist-packages (from fritzconnection<1.0.0,>=0.8.0->fritzcollectd) (2.22.0)
Building wheels for collected packages: lxml
  Building wheel for lxml (setup.py) ... done
  Created wheel for lxml: filename=lxml-4.5.1-cp38-cp38-linux_armv7l.whl size=8396733 sha256=5242843a7a80ff811fdb42fccccc89e95dad5ce3869bb876ae996e6e372e77ec
  Stored in directory: /root/.cache/pip/wheels/fb/57/57/2865f2c86ec8aed861a9a06074bf9ac8fa97b5a15eb433d6bf
Successfully built lxml
Installing collected packages: lxml, fritzconnection, fritzcollectd
  Attempting uninstall: lxml
    Found existing installation: lxml 4.5.0
    Uninstalling lxml-4.5.0:
      Successfully uninstalled lxml-4.5.0
  Attempting uninstall: fritzconnection
    Found existing installation: fritzconnection 0.7.3
    Uninstalling fritzconnection-0.7.3:
      Successfully uninstalled fritzconnection-0.7.3
  Attempting uninstall: fritzcollectd
    Found existing installation: fritzcollectd 0.6.3
    Uninstalling fritzcollectd-0.6.3:
      Successfully uninstalled fritzcollectd-0.6.3
Successfully installed fritzcollectd-0.7.0 fritzconnection-0.8.5 lxml-4.5.1

Big thanks @kbr and @SuperSandro2000 !!