Fix issue 55 if phonebook contains same named entries, and..

kbr / fritzconnection

Python-Tool to communicate with the AVM Fritz!Box by the TR-064 protocol and the AHA-HTTP-Interface

MIT License

304 stars 59 forks source link

Fix issue 55 if phonebook contains same named entries, and.. #56

Closed bufemc closed 2 years ago

bufemc commented 4 years ago

.. optionally remove internal numbers by additional parameter keep_internals=False. Default is True so the behavior is backward compatible to previous versions.

bufemc commented 4 years ago

Hi, no worries. I believe you can do it (better) and I lost few hair when trying to read the attributes in the used processor ;)

I am also not so satisfied with my provided ”hack” for the other ”issue”, how to add a contact to a phonebook. It works, but is not clean.

bufemc commented 3 years ago

To be noted.. Anyway we should only keep numbers starting with a digit.. Reason: it seems there could be other internal numbers starting with #.

chemelli74 commented 2 years ago

@bufemc, is the issue still valid ? If so can you please rebase this PR ?

Simone

kbr commented 2 years ago

I close this, as it has was not handled so far or will get handled in the near future. Also the issue can get solved with a filter on top of the library at application level. But please feel free to reopen in case of need.