improvement to toast.promise

kbrgl / svelte-french-toast

🍞🥂 Buttery smooth toast notifications for Svelte

https://svelte-french-toast.vercel.app/

MIT License

809 stars 28 forks source link

Open winston0410 opened 1 year ago

winston0410 commented 1 year ago

This PR aims to solve the following issues for toast.promise

support dynamic toast message based on promise's result, fallback to the static message provided initially
handle edge case where toast.loading has been set with {duration: Infinity}, and toast.success and toast.error will not go away as well

The only thing that I am not sure is why is resolveValue function used there previously.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
svelte-french-toast	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 8, 2023 at 9:38PM (UTC)

winston0410 commented 1 year ago

@kbrgl what do you think about this?