search

kbrgl / svelte-french-toast

🍞🥂 Buttery smooth toast notifications for Svelte
https://svelte-french-toast.vercel.app/
MIT License
809 stars 28 forks source link

feat: RTL support #39

Closed thenbe closed 1 year ago

thenbe commented 1 year ago

Fixes #28

Instead of asking users to specify a relative direction (right, left), we can take a page out of CSS logical properties and use start and end as opposed to left and right.

As an example, here is how tailwindcss handled this recently: https://github.com/tailwindlabs/tailwindcss/pull/10166

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-french-toast ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 7:04pm
kbrgl commented 1 year ago

Thank you so much for the PR! I’ll review this as soon as I get time.

kbrgl commented 1 year ago

Ha, this is actually pretty short and sweet. Merging now. Thanks again.

kbrgl commented 1 year ago

We’re probably going to want to document these new features (as well as all the older undocumented ones). I’m going to add an issue for that.

thenbe commented 1 year ago

Ha, this is actually pretty short and sweet. Merging now. Thanks again.

Yeah CSS is admittedly doing all of the heavy lifting here.