search

kbrgl / svelte-french-toast

🍞🥂 Buttery smooth toast notifications for Svelte
https://svelte-french-toast.vercel.app/
MIT License
838 stars 30 forks source link

Some UI changes #4

Closed babakfp closed 2 years ago

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
svelte-french-toast ✅ Ready (Inspect) Visit Preview Jun 18, 2022 at 9:58AM (UTC)
kbrgl commented 2 years ago

Thanks for the PR. I'll merge it in when I have an opportunity to review the changes! 😄

kbrgl commented 2 years ago

I appreciate your time on this, but I can’t merge this PR on principle since it makes vague changes with unclear benefits, while also introducing several issues:

  1. The height of the code samples for the examples is changed. Having a large, explicitly sized box with vertically centered is intended behavior, since it prevents the code sample from jumping around when trying different examples.
  2. The code samples themselves are changed, which breaks the error and multiline samples by introducing syntax errors.