search

kbrgl / svelte-french-toast

🍞🥂 Buttery smooth toast notifications for Svelte
https://svelte-french-toast.vercel.app/
MIT License
809 stars 28 forks source link

dark mode button on demo website is not working #66

Open sina-salahshour opened 5 months ago

sina-salahshour commented 5 months ago

https://svelte-french-toast.vercel.app/

examples section.

Dark mode button opens a light toast.

kworkbee commented 4 months ago

https://github.com/kbrgl/svelte-french-toast/blob/2dd9abc205fe7e161802593e03b680350b237184/src/lib/components/ToastWrapper.svelte#L47-L53

It appears that the assignment of the background attribute is missing. @kbrgl

kworkbee commented 4 months ago

https://github.com/kbrgl/svelte-french-toast/pull/48 According to this PR, it seems that the props property should be used, but it seems that it hasn't been released yet?

sina-salahshour commented 4 months ago

48 According to this PR, it seems that the props property should be used, but it seems that it hasn't been released yet?

I have no clue but can it be because the package version hasn't changed since? maybe vercel cached the package on last version change (from 1.1 to 1.2) and used that on other deploys... because i tested locally and dark theme styles works fine.

kworkbee commented 4 months ago

I checked again and it's working fine 😅

toast("TEST", {
          icon: "👏",
          style: "color: #fff; background-color: #333; font-size: 20px;",
        });