search

kbroman / qtl

R/qtl: A QTL mapping environment
https://rqtl.org
GNU General Public License v3.0
77 stars 45 forks source link

Minor extension to scanonevar() #38

Closed rcorty closed 9 years ago

rcorty commented 9 years ago

scanonevar() can now fit dominance effects (set parameter "dom" = TRUE). I added estimated effect sizes to the return value, which I am planning to use in a new plot type.

I also slightly clarified one of the tests for scanonevar() in test_scaneonevar.R

kbroman commented 9 years ago

Thanks!

Unfortunately, I'm traveling at the moment, so it may take a couple of weeks for me to review and merge your work.

kbroman commented 9 years ago

Could you also revise the help file for scanonevar(), plus add a help file for plot.scanonevar()?

The initial comment in the file for plot.scanonevar should be revised to match the code.

rcorty commented 9 years ago

I've changed quite a few things related to scanonevar() in my branch of R/qtl. I'll make a new pull request when it all works well and will include updated help files.