fdsf

[kbromer]

dsf

[kbromer]

**lurch: review

[LurchTheButler]

PING!

[kbromer]

**lurch: review

[LurchTheButler]

General

• [ ] All new pages, classes or metadata conform to naming conventions

  Tests

• [ ] Test coverage is > 85%
• [ ] Tests are in separate test classes
• [ ] Test conform to naming conventions
• [ ] All tests have positive and negative assertions
• [ ] Test data properly stands-up TDTM records where needed
• [ ] Tests make use of StartTest() and StopTest()
• [ ] Tests leverage different users and profiles

  Visualforce

• [ ] This request includes VisualForce
  • [ ] Request meets mobile requirements
  • [ ] All pages are 508 compliant

[kbromer]

**lurch: review

[LurchTheButler]

General

• [ ] All new pages, classes or metadata conform to naming conventions

Tests

• [ ] Test coverage is > 85%
• [ ] Tests are in separate test classes
• [ ] Test conform to naming conventions
• [ ] All tests have positive and negative assertions
• [ ] Test data properly stands-up TDTM records where needed
• [ ] Tests make use of StartTest() and StopTest()
• [ ] Tests leverage different users and profiles

Visualforce

• [ ] This request includes VisualForce
  • [ ] Request meets mobile requirements
  • [ ] All pages are 508 compliant

[kbromer]

**lurch: review

[LurchTheButler]

General

• [ ] All new pages, classes or metadata conform to naming conventions

[kbromer]

**lurch: review apex visualforce

[LurchTheButler]

General

• [ ] All new pages, classes or metadata conform to naming conventions

Apex

• [ ] This request includes Apex
  • [ ] Sharing/Without/None has been explicitly determined and explained
  • [ ] FLS is appropriately checked and enforced
• [ ] Custom settings access is done through appropriate interfaces
• [ ] Methods are appropriately sized and scopes
• [ ] Inner classes utilized where appropriate
• [ ] Dependencies are done explicitly or have been noted where dynamic
• [ ] API Version is explicitly set to the latest or otherwise indicated as to why not
• [ ] Code is bulkified
  • [ ] No SOQL or DML in For loops
  • [ ] Async calls in For loops are properly rate limited
  • [ ] Code utilized DML wrapper where appropriate
• [ ] No new triggers have been added
• [ ] All currency operations are multi-currency capable and compliant
• [ ] Any new triggered functionality properly implements TDTM interface
  • [ ] A new TDTM record has been added to the install script for this class
  • [ ] Trigger recursion is handled appropriately
• [ ] All SOQL queries have been written as selectively as possible, and limited where appropriate
• [ ] Code is properly wrapped in try-catch and exceptions handled through the error handling framework
• [ ] This request includes batch or queueable apex
  • [ ] Batch apex is appropriately daisy-chained where required
• [ ] This request includes scheduable jobs
  • [ ] Scheduable jobs are properly injected into the scheduable framework

Tests

• [ ] Test coverage is > 85%
• [ ] Tests are in separate test classes
• [ ] Test conform to naming conventions
• [ ] All tests have positive and negative assertions
• [ ] Test data properly stands-up TDTM records where needed
• [ ] Tests make use of StartTest() and StopTest()
• [ ] Tests leverage different users and profiles

Visualforce

• [ ] This request includes VisualForce
  • [ ] Request meets mobile requirements
  • [ ] All pages are 508 compliant
  • [ ] All labels and text are translatable via Custom Labels
  • [ ] This VF has a controller
  • [ ] Controller sharing has been determined
  • [ ] Parameters are properly escaped
• [ ] CSRF protections are in place
• [ ] FLS is appropriately checked and enforced
• [ ] Business logic is not included in the controller
• [ ] Controller uses bind variables in SOQL
• [ ] Viewstate is managed through use of transients, etc.
  • [ ] Page includes custom CSS
  • [ ] Page include custom JS
  • [ ] Page includes new libraries or library requirements
  • [ ] Libraries are zipped and hosted in Static Resources
• [ ] Visualforce page utilizes existing VF components
• [ ] Templates are used where appropriate
• [ ] Visualforce page is an embedded component or page
• [ ] Visualforce page accepts user parameters for extendability
• [ ] User parameters are properly escaped and cleaned

[kbromer]

**lurch:review lightning

[LurchTheButler]

General

• [ ] All new pages, classes or metadata conform to naming conventions

Lightning