search

kbrsh / moon

🌙 The minimal & fast library for functional user interfaces
https://moonjs.org
MIT License
6k stars 200 forks source link

make HTTP request headers optional #260

Closed kbrsh closed 5 years ago

kbrsh commented 5 years ago

Extra HTTP request headers are usually not required. This change makes them optional and makes it so that the HTTP driver only requires the url field to perform a request. This also adds tests for using default HTTP requests that are both successful and result in an error.

codecov-io commented 5 years ago

Codecov Report

Merging #260 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   93.34%   93.35%   +<.01%     
==========================================
  Files          26       26              
  Lines         842      843       +1     
  Branches      177      178       +1     
==========================================
+ Hits          786      787       +1     
  Misses         49       49              
  Partials        7        7
Impacted Files Coverage Δ
packages/moon/src/http/driver.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d7174e...9838956. Read the comment docs.