kbrsh / wing

:gem: A beautiful CSS framework designed for minimalists.
https://kbrsh.github.io/wing
MIT License
2.01k stars 160 forks source link

Browser Testing #72

Open winghimjns opened 6 years ago

winghimjns commented 6 years ago

Hi Kabir,

I used Wing in one project, a simple one page site. I left it for a while and just tested it yesterday in iPad's browser. Not sure if it's the problem in my code or wing's.

Appreciate that this framework is lightweight but gets everything basic. I tried this framework because sometimes when I use bootstrap I just need the html reset, grid system and couple of variables and mixins. It's good to have less predefines and keep the most frequent use features.

But seems like the grid system is not work properly in iPad devices. What I saw is each col col-*, first one is. col col-9 filled 100% width of the row, and the 2nd one col col-3 is started to be overflowed.

It's important to note that the browser I was using is out of date. But I don't find any documentations about the browser compatibility.

Will browser testing be in the schedule? Or shall we make a browser compatibility list by checking the modern features we are using especially flex?

Cheers,

Wing Him

kbrsh commented 6 years ago

Hey,

I appreciate the detailed response. The col classes aren't meant to be used together, which looks like the main problem here. col resizes to fill the rest of the space, while col-* fills up a fixed amount of width.

Try using the appropriate col classes and see if that works. I might add browser tests for this type of stuff one day as well.

winghimjns commented 6 years ago

Thanks for the details, I think I used it incorrectly.

I just have a look to the unminified production .css again. And realist that the one I am using on unpkg.com (https://unpkg.com/wingcss@1.0.0-beta/dist/wing.css) is not the same one as this repository's master especially the grid system, even with the same version code 1.0.0-beta.

The one here is using width attr for col-* and the unpkg one is using flex attr.

Is this an issue?

Thanks

kbrsh commented 6 years ago

Nope, it's not an issue. The version on this repository is the current development of 1.0.0.