Closed Art4 closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
81259f3
) 97.63% compared to head (2f6b3d7
) 97.71%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
AbstractApi::get()
does not allow to specify the content type header for the request and could returnstring|array|SimpleXMLElement|false
. In this PR I moved the logic from this method into the API classes. There we can better see the possible return types and I've updated the phpdoc return types accordingly.Thanks to new and improved tests I could also fix a bug in
Redmine\Api\Attachment::download()
returning false on error instead of the HTML 404 error page.This PR removes the
@internal
mark from the newHttpClient
andRequest
interfaces and deprecatesAbstractApi::get()
.I will do the same for
AbstractApi::post()
,AbstractApi::put()
andAbstractApi::delete()
in separate PRs, see #372.Requires #378.