kbsali / php-redmine-api

A simple PHP Redmine API client, Object Oriented
MIT License
420 stars 183 forks source link

PHP 8.4 Fix implicitly nullable parameter declarations deprecations #407

Closed Art4 closed 4 months ago

Art4 commented 4 months ago

This PR fixes the PHP 8.4 deprecation warnings for implicitly nullable parameter declarations, see https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

PHP 8.4 deprecates implicitly nullable types. PHP applications are recommended to explicitly declare the type as nullable. All type declarations that have a default value of null, but without declaring null in the type declaration emit a deprecation notice

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.47%. Comparing base (31768d5) to head (cc14f15).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v2.x #407 +/- ## ========================================= Coverage 98.47% 98.47% Complexity 609 609 ========================================= Files 29 29 Lines 1841 1841 ========================================= Hits 1813 1813 Misses 28 28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.