search

kbss-cvut / 19msmt-distribution

MSMT Reliability Management System
GNU General Public License v3.0
0 stars 0 forks source link

Fix element IRIs generated by convert-document service #29

Closed kostobog closed 2 years ago

kostobog commented 2 years ago

IRIs of created entities, e.g. components, functions and failure modes should be prefixed by the IRI of type of the entity. For example:

kostobog commented 2 years ago

@Matthew-Kulich, can you check if the issue is resolved correctly?

Matthew-Kulich commented 2 years ago

@kostobog It works.

Matthew-Kulich commented 2 years ago

Also there's a one bug with cardinality constraint. For example when we get this component

fta:twin-spars-18  a     fta:Component ;
        fta:hasName      "Should you be more specific ?" , "twin spars" ;
        fta:isPartOf     fta:Empennage-17 ;
        fta:origin       fmea:twin-spars-18 ;
        dc-terms:source  "https://kbss.felk.cvut.cz/brat/#/19msmt/BlueSky/DA42-POH--has-component/DA42-POH-38?focus=T18"
kostobog commented 2 years ago

This should be already fixed. Try using the newest version of the converter. The "twin spars" example does not have multiple hasName, see https://kbss.felk.cvut.cz/19msmt-demo/fta-fmea-converter/service?_pId=convert-document

@Matthew-Kulich

Matthew-Kulich commented 2 years ago

Yeah I know, I meant if this case can appear in the future, but i guess not. @kostobog