search

kbss-cvut / fta-fmea-ui

GNU General Public License v3.0
5 stars 6 forks source link

Material UI theme provokes FTA-FMEA to crash #305

Open LaChope opened 4 months ago

LaChope commented 4 months ago

NOTE: #343 might solve this issue, but #365 must be completed first to be able to test the fix.

@blcham @Kasmadei On both the development server and dockerized version, app crashes with:

Firefox error: Image

Chrome error: Image

The issue comes very probably from the changes of this commit.

LaChope commented 4 months ago

309 fixes part of it. When using internal auth, it works when loading the app for the first time, but if you refresh (also CTRL + F5), app crashed with the same error as above. This behavior occurs even after 155a79d and 09517db, we just did not try to refresh page before.

I tried to remove all useTheme hooks from all files, but the issue still occurs.

LaChope commented 4 months ago

Reopening as not completed (see comment just above)

blcham commented 4 months ago

It might be little relevant to: https://github.com/kbss-cvut/record-manager-ui/issues/125#issuecomment-2077283029

blcham commented 3 months ago

@LaChope what do you propose to do with this? Should we put it to TODO ?

LaChope commented 3 months ago

Yes, also I am updating the description as #365 should be completed before this.

blcham commented 2 months ago

@LaChope I guess this is not relevant for the delivery -- putting it into "technical debt sprint"

LaChope commented 2 months ago

@blcham yes