Small issues in FTA tree

kbss-cvut / fta-fmea-ui

GNU General Public License v3.0

5 stars 6 forks source link

Small issues in FTA tree #469

Open blcham opened 1 week ago

blcham commented 1 week ago

[x] manually defined failure rate issue

[x] disabling edit of FTA nodes
[x] radio button should not be on simple basic node
[ ] read-only value should be properly visualized

Kasmadei commented 1 week ago

@blcham As I mentioned, it looks like the issue with the double-click is related to the node. The node http://onto.fel.cvut.cz/ontologies/fta-fmea-application/fault-event/instance1204570762 (which should be clickable) has the property "isReference: true", but it lacks the references.isPartOf property, which is necessary to enable the double-click functionality.

Kasmadei commented 1 week ago

@blcham Fix for point number 3: https://github.com/kbss-cvut/fta-fmea-ui/pull/477

kostobog commented 1 week ago

@blcham @Kasmadei Regarding issue with double-click on external reference node. For me it works with current version in main. It works in docker as well. The isPartof property is populated.

However, the algorithm searching for the node in the tree in Editor.redirectToInstance works only for level 2 graphs. This needs to be rewritten so that it works for trees with arbitrary depth.

Kasmadei commented 6 days ago

Fix for last point: https://github.com/kbss-cvut/fta-fmea-ui/pull/490