User can't use operational failure rate if it is missing in the data

kbss-cvut / fta-fmea-ui

GNU General Public License v3.0

7 stars 6 forks source link

User can't use operational failure rate if it is missing in the data #525

Open kostobog opened 4 months ago

kostobog commented 4 months ago

Operational failure rate cannot be used if it is not present in the data.

Tasks:

[x] Open access to failure rate api in analytics server module - resolved in kbss-cvut/ava-analytics#39
[x] Fix SNS export - add general fault event types (not related to aircraft) kbss-cvut/23ava-distribution#129
[x] kbss-cvut/fta-fmea-ui#533 - kbss-cvut/fta-fmea-ui#534

blcham commented 4 months ago

Currently this was done by workaround -- https://github.com/kbss-cvut/ava-analytics/pull/39, which should be properly fixed in #532.

blcham commented 4 months ago

@kostobog so does it work now ?

kostobog commented 1 week ago

@blcham This works. User can user operational failure rate if it is not calculated yet.

First user has to click the tree evaluation button. Operational failure rates in the tree will be updated according to the value of min. operational hours field next to the button even if there is an error message that the tree could not be evaluate due to unspecified failure rates in some of of the leaf nodes.

To see the newly added operational failure rates in the SNS node the tree must reloaded. The tree could be reloaded in several ways:

automatically if the tree was evaluated successfully without error messages for missing failure rates in leaf nodes
by updating one of the nodes, e.g. change the name of change the failure rate selection or manual failure rate.
exit the tree and open it again

blcham commented 1 week ago

@kostobog ok I guess the workaround you mentioned is good enough as it is, what do you think? If so i suggest to close this issue.

kostobog commented 1 week ago

@blcham Open access workaround works but I am not sure if we want keep it?

Otherwise, I can improve user experience by reloading the tree even if there were missing failure rates at the leaf events. This way the user will always need to only click the evaluate button to see the missing operational failure rates.

blcham commented 1 week ago

If it does not introduce other issues it would be better UX if you reload.

blcham commented 12 hours ago

So we can close this issue if:

[ ] refresh of failed evaluation works
[x] if the ticket about securing ava-analytics contains also adaptation of 23-ava see the issue

blcham commented 12 hours ago

@kostobog please see my last comment