kbss-cvut / react-maintenance-planner

React component to visualize and manage maintenance plans.
GNU Lesser General Public License v3.0
0 stars 1 forks source link

Remove resources from tree #36

Closed LaChope closed 2 years ago

LaChope commented 2 years ago

Related to https://github.com/kbss-cvut/csat-maintenance-planner/issues/25#issue-1256349981

netlify[bot] commented 2 years ago

Deploy Preview for react-maintenance-planner ready!

Name Link
Latest commit c1ac686e6987d67d76540bee21f6156b79670a76
Latest deploy log https://app.netlify.com/sites/react-maintenance-planner/deploys/62b05ed2fc88e800099b9d1c
Deploy Preview https://deploy-preview-36--react-maintenance-planner.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

blcham commented 2 years ago

@PluharVit

blcham commented 2 years ago

@LaChope remove works nicely,

LaChope commented 2 years ago

Indeed it is quite dangerous. No it is not implemented but it could be, otherwise here are possibilities:

blcham commented 2 years ago

I would do for now undo-redo only, and wait what MK says about it ... To me best solution would be similar as it is in gmail.

1) whenever you do action there is message showing that you did it 2) you can redo it very easily using "Undo" link

image

However, i still believe this is only in category just "nice to have" ... and we have many "must"s probably

blcham commented 2 years ago

So to summarize I would add ticket to solve undo-redo. The other stuff discussed here can be formulated somewhere as well if you want to discuss it with MK.

LaChope commented 2 years ago

@blcham @PluharVit I assume I can merge this PR and create new issue for undo/redo ? https://github.com/kbss-cvut/react-maintenance-planner/issues/39#issue-1277029603

blcham commented 2 years ago

I agree.