kbss-cvut / react-maintenance-planner

React component to visualize and manage maintenance plans.
GNU Lesser General Public License v3.0
0 stars 1 forks source link

removable items / milestones #75

Closed PluharVit closed 1 year ago

PluharVit commented 1 year ago

Resolves #54

netlify[bot] commented 1 year ago

Deploy Preview for react-maintenance-planner ready!

Name Link
Latest commit 3a78894f47f0697f4ffb186cdf0ead538fd81364
Latest deploy log https://app.netlify.com/sites/react-maintenance-planner/deploys/6349632206439e0008533787
Deploy Preview https://deploy-preview-75--react-maintenance-planner.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

LaChope commented 1 year ago

Did you commit everything? It does not work on the deploy here

image

Even when I create new task, it does not work

image

PluharVit commented 1 year ago

What do you mean? I don't see anything wrong.

LaChope commented 1 year ago

When I am using the deploy preview (https://deploy-preview-75--react-maintenance-planner.netlify.app/), I do not see any delete option (as shown on screenshots above). I tried on existing tasks, and I also created new task and still couldn't see any delete icon

PluharVit commented 1 year ago

Both screenshots you shared are creating task. The delete button is displayed only in editing modal. Using the link you sent, it works fine for me, see bellow.

obrazek

LaChope commented 1 year ago

How do I get the editing modal then? I was double clicking on the task. I will investigate if it comes from my machine but it seems weird.

PluharVit commented 1 year ago

Just click on the edit icon.

LaChope commented 1 year ago

Ooooh ok I get it now. I thought we want to completely get rid of these icons and that everything would be handled with the modal, can you make this modification?

PluharVit commented 1 year ago

Yeah, okey, I'll look at it.

PluharVit commented 1 year ago

@LaChope So I setted the editing of an item to a double click action. Also got rid of those icons.

LaChope commented 1 year ago

That's great, LGTM