Autocomplete tree with dereferenceable values does not work correctly

kbss-cvut / record-manager-ui

GNU Lesser General Public License v3.0

0 stars 2 forks source link

Autocomplete tree with dereferenceable values does not work correctly #133

Closed blcham closed 6 months ago

blcham commented 6 months ago

Tested on A1 form.

LaChope commented 6 months ago

@blcham It is supposed to work the other way around, if should not be a link if dereferenceable is set to true (to not break default behavior). If it does not make sense semantically, we should rename dereferenceable.

blcham commented 6 months ago

To me, the name makes sense, and the following behavior:

provides-dereferencable-answer-values = true -- show links. See dereferencable URIs. Also, it makes sense that this is the default value because if you have a link in the autocomplete tree, we can assume it is clickable. The property could also be read as provides-clickable-anwer-values.
provides-dereferencable-answer-values = false -- do not show links.

LaChope commented 6 months ago

I cannot find it written in ticket, but we discussed having it this way to keep the default behaviour of intelligent-tree (always show as link). But, if you think it is better this way, I will change it.

blcham commented 6 months ago

I feel we are proposing same, or not? I found only this comment: https://github.com/kbss-cvut/s-forms/pull/263#discussion_r1472540999