search

kbss-cvut / record-manager-ui

GNU Lesser General Public License v3.0
0 stars 2 forks source link

Records in record list should be links #79

Open blcham opened 5 months ago

blcham commented 5 months ago

It should be possible to open record to a new tab from record-list. Note that it was already implemented before (see git history).

LaChope commented 3 months ago

I cannot find anything in history (no branch or specific commit), was it pushed?

blcham commented 3 months ago

I just wanted to say that it used to work long time ago, so when looking to a history of a relevant file you should see it (but even if you find it I am not sure if it helps).

You would definitely see it in git history of RecordRow.js. Most likely, it commit 4f015b8ae1ae3de92aaf10e2278fd479f61946f2, where it stopped working.

blcham commented 3 months ago

Here is related issue https://github.com/kbss-cvut/record-manager-ui/issues/125

LaChope commented 2 months ago

Re-opening as reverted (20cdcb0) because tests are failing: Error: Uncaught [Error: Invariant failed: You should not use <Link> outside a <Router>].

blcham commented 1 month ago

Currently this is not that relevant, thus putting it to TODO state.