Open LaChope opened 6 months ago
Name | Link |
---|---|
Latest commit | fb8d67b4c46ce6ca65fc774108c0de361851fcbb |
Latest deploy log | https://app.netlify.com/sites/s-forms-kbss/deploys/66154de1b1a38100097c353a |
Deploy Preview | https://deploy-preview-315--s-forms-kbss.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Good point that it is breaking change, although not for SPipes applications but SPipesComponents. Thus we need to do it little later after we publish new version of SForms. Then we publish next version that will contain this change.
Moreover, we need to discuss conventions.E.g. we have:
Vocabulary.XSD.MAX_EXCLUSIVE
but
Vocabulary.RDFS_LABEL
-- we could also have Vocabulary.DOC
, Vocabulary.FORM
etc.
Other issues:
Vocabulary.DCTERMS
with prefix "http://purl.org/dc/terms/", i.e. it will end up http://purl.org/dc/terms/description
.BTW, you can use https://prefix.cc/ to search for meaningful prefixes of URIs.
@LaChope I changed last comment to address "Other issues". Note that after changing HELP_DESCRIPTION
we should change also forms (e.g. ava-model).
Moreover, we need to discuss conventions.E.g. we have:
Vocabulary.XSD.MAX_EXCLUSIVE
butVocabulary.RDFS_LABEL
-- we could also haveVocabulary.DOC
,Vocabulary.FORM
etc.
I am not sure I understand fully in the end. For instance, these should be refactored like so?
static HAS_OPTION => FORM.HAS_OPTION
static HAS_OPTIONS_QUERY => FORM.HAS_OPTION_QUERY
static HAS_ANSWER => DOC.HAS_ANSWER
...
yes
Resolves #279.
IMPORTANT NOTE: After this is merged, all applications using s-forms will break and will need to be refactored according to this PR.