Github actions for dependbot fail to push image

kbss-cvut / s-pipes-editor-ui

MIT License

0 stars 0 forks source link

Github actions for dependbot fail to push image #21

Open blcham opened 1 year ago

blcham commented 1 year ago

This is because dependbot has no access right to push docker-image which is i guess all right.

We should fix it in a way that if the pull request is from dependbot, we should not try to push image.

A/C:

skip publish docker image workflow (like here)
add CI workflow build directly with npm (and execute tests if there are any) (like here)

blcham commented 2 days ago

@palagdan Sorry, I changed my mind. It is quite useless to make a docker image with that action. i suggest to skip it as done in: https://github.com/kbss-cvut/record-manager-ui/blob/64ff5e3c96d988a20e8effcd585ff9958777122f/.github/workflows/publish-docker-image.yml#L17

I suggest doing it exactly the same as in record-manager-ui (of course as usual I will be happy for any discussion on that) so i modified A/C.

blcham commented 2 days ago

@palagdan BTW, I am not sure you can test GH actions without actually committing to main ... so if you need it, do it directly to main (just do not forget to reference issue from commits).