search

kbss-cvut / s-pipes

Tool for execution of RDF-based pipelines.
GNU Lesser General Public License v3.0
4 stars 5 forks source link

Module.executeSelf should not loadConfiguration #182

Closed blcham closed 3 months ago

blcham commented 1 year ago

Investigate why it calls loadConfiguration and possibly refactor it out.

Related to testing -- in tests of method executeSelf we must create resource as can be seen here: https://github.com/kbss-cvut/s-pipes/pull/172#discussion_r1270605746

blcham commented 1 year ago

@rodionnv I looked to the source code and executeSelf() does not load the configuration as expected.

Thus this ticket is irrelevant. To prove I implemented your tests see https://github.com/kbss-cvut/s-pipes/pull/172/commits/3b65e8dd86d3a10127d6676107fef8d55104372d.

blcham commented 1 year ago

@rodionnv please close this ticket if you agree.