search

kbss-cvut / s-pipes

Tool for execution of RDF-based pipelines.
GNU Lesser General Public License v3.0
4 stars 5 forks source link

Fixed issue 231 #240

Closed MSattrtand closed 4 months ago

MSattrtand commented 4 months ago

Fixes issue #231.

image If an incorrect query causes an exception, the query is logged now.

blcham commented 4 months ago

1) for referencing issues use # ... as it is very well integrated with github + use more specific commits: Fixed issues 231 ---> [#231] Improve logging for queries when parse error occurs 2) line 32 is not telling me where to look. I think you logged a shorter query without prefixes. BTW, this was the main motivation for this issue.

MSattrtand commented 4 months ago

The stack trace shows that the exception has occurred at the perform function of the ParserARQ class right here: image The last of the s-pipes functions that may cause the exception are ApplyConstructModule and BindBySelectModule, so if we assume that foreign libraries are working correctly, the main reason the parser may fail is that our query is truly incorrect. Therefore, I thought logging only the query and the stack trace was enough for debugging. NB: There are more functions that may (theoretically) send incorrect queries to the parser; ApplyConstructModule and BindBySelectModule are the only modules I can properly test because they are called during the execution of the Hello, World script.

blcham commented 4 months ago

The stack trace shows that the exception has occurred at the perform function of the Parse .....

Not sure what you mean, but I am saying that the error you are logging is not good enough because you won't be able to find the error within the query. Try to read what you sent me above and find the error based on the coordinates: in you output: ... at line 32, column 7