search

kbss-cvut / termit

An advanced SKOS terminology manager linking concepts to their definitions in documents
GNU General Public License v3.0
8 stars 9 forks source link

Test failure while running on Windows #275

Closed lukaskabc closed 6 days ago

lukaskabc commented 3 months ago

When run on Windows, the test fails.

System information

Windows 10 Pro 22H2 Oracle OpenJDK version 17.0.1 (build 17.0.1+12-LTS-39) Active Maven profiles: standalone,graphdb

Test output

[ERROR] Failures: 
[ERROR]   HtmlTermOccurrenceResolverTest.findTermOccurrencesSetsFoundOccurrencesAsApprovedWhenCorrespondingExistingOccurrenceWasApproved:193 
Expected: not a collection containing "http://onto.fel.cvut.cz/ontologies/application/termit/pojem/navržený-výskyt-termu"
     but: was <[http://onto.fel.cvut.cz/ontologies/application/termit/pojem/navržený-výskyt-termu]>
[INFO] 
[ERROR] Tests run: 1407, Failures: 1, Errors: 0, Skipped: 0
[INFO]

Line 193 permalink

ledsoft commented 1 week ago

I am unable to reproduce it (Windows 11, JDK Temurin 21). Does the failure happen occasionally, or every time?

lukaskabc commented 1 week ago

After enabling the test for Windows and rerunning it on Windows 11, JDK Temurin 21 with
clean test -Dtest=HtmlTermOccurrenceResolverTest the test still fails. So far, it has failed every time.

ledsoft commented 1 week ago

Yeah, you are right. I am an idiot, I forgot the test was disabled on Windows... Now I can reproduce it as well.

ledsoft commented 6 days ago

Of course it was a linefeed issue. Added configuration to use consistent line endings for files. Hopefully that should resolve the problem.