search

kbuffington / Georgia

Dynamic foobar2000 theme
286 stars 16 forks source link

Cover art potential bug in playlist view #27

Closed Artins90 closed 4 years ago

Artins90 commented 4 years ago

I am not sure if this is strictly related to Georgia of if it's caused by other factors, I noticed that there is a line going across the last cover and song name in the playlist. Resizing the window allows me to move this line up and down, this is on a 4K screen. Line when placed in the last slot:

Capture2

No line on the cover when scrolling the same album 1 position up from the last position, the line moves to the track number 2 instead:

Capture3

It might be hard to see, here is a zoomed version:

Capture3
kbuffington commented 4 years ago

Yeah, this is a bug in either foo_jscript_panel or GDI itself, dealing with gradients which contain alpha values. I have to draw a gradient from like RGBA(32,32,32,255) to RGBA(32,32,32,0), and sometimes the last line which should have 0 alpha somehow wraps to 255 alpha.

It has to do with the size of the gradient itself which means it's susceptible to screen resolution as well. It's been driving me nuts for years, because I can't fix it all the time. I might look into what's happening in foo_jscript_panel and see if I can create a fix.

Artins90 commented 4 years ago

Thank you for looking into this. It's not a huge issue and it's barely noticeable, you might want to give it less priority if you are working on something else.

kbuffington commented 4 years ago

Think this is now fixed in 1.1.7. Just had to change the orientation of the FillGradRect and the order of colors. Reopen if you're still having problems.