kbuffington / Georgia

Dynamic foobar2000 theme
284 stars 16 forks source link

Foobar v1.6 update causing immediate crash #48

Closed Madmax4434 closed 4 years ago

Madmax4434 commented 4 years ago

Seems to start up fine in safe mode but crashes immediately when updating to 1.6 and starting with Georgia applied.

mist475 commented 4 years ago

this is because of jscript panel being incompatible, if you update jscriptpanel you can start the program, you can't play anything though

Madmax4434 commented 4 years ago

Checked the foo jscript panel version and I'm on the latest. Pretty sure it isn't that since it was working up until I updated

mist475 commented 4 years ago

hmm, odd. for me it launches fine, then the jscript panel turns red, you sure you're on 2.4.1.1?

Madmax4434 commented 4 years ago

Seems I was on 2.3.6.1 from kbuffington, updated to 2.4.1.1 and facing the same issue as you now. Rolled back to foobar 1.5.6 and it's working fine though.

kbuffington commented 4 years ago

Ugh, of course this would happen before I'm ready to release the latest version. I'll take a look. Not sure what changed since the last beta I was working with.

kbuffington commented 4 years ago

I cannot get this to crash using either version 2.4.0 or 2.4.1.1. There might have been something fixed since the 1.1.9 release? What does the console say?

Madmax4434 commented 4 years ago

With jscript panel 2.3.6.1, it's stable on 1.5.6 but crashes on 1.6 foobar. With 2.4.1.1 it should turn red on both if you try to perform any activity. Try editing a song property for example.

bobstrain commented 4 years ago

This is the console output on error:

JScript Panel v2.4.1.1 (Georgia by Mordred) Errore di run-time di JavaScript: Azione non valida per l'oggetto File: C:\Users\...\AppData\Roaming\foobar2000\georgia\js\CaTRoX_QWR\Panel_Library.js Line: 2697, Col: 3

For what I understand it's related to window.CreateTooltip, from marc2k3 notes on 2.4.1:

Update docs to make it clear that only a single call to window.CreateTooltip is permitted per panel instance. Errors will now be thrown on any subsequent calls. Additionally, the ITooltip interface no longer has a Dispose method.

Hope this help

BenGroeneveld commented 4 years ago

I am experiencing this problem as well (foobar2000 1.6, Georgia 1.1.9 and JScript Panel v2.4.1.1).

The theme will load, but it will give an JavaScript error within a few seconds, seemingly regardless of any actions.

I received this error message:

JScript Panel v2.4.1.1 (Georgia by Mordred)
JavaScript runtime error:
Object doesn't support this action
File: C:\Users\[USERNAME]\AppData\Roaming\foobar2000\georgia\js\CaTRoX_QWR\Panel_Library.js
Line: 2697, Col: 3

Besides that, I also noticed there is no option to select the "Chakra" (or any other) script engine in JScript Panel v2.4.1.1, not sure if this is helpful, but I thought I'd share.

kbuffington commented 4 years ago

Should be fixed in 1.1.10