search

kbuffington / Georgia

Dynamic foobar2000 theme
284 stars 16 forks source link

logo is null #98

Closed omercibcp closed 3 years ago

omercibcp commented 3 years ago

Error: Spider Monkey Panel v1.4.1 ({B1207B07-4043-4046-AE1A-4AAB5F5AD9F1}: Georgia v2.0.2 by Mordred) logo is null

File: georgia-main.js Line: 1528, Column: 4 Stack trace: on_playback_new_track@georgia-main.js:1528:4

kbuffington commented 3 years ago

Thanks. This has already been fixed. Issue is Georgia is finding an invalid image. Either a file misnamed with the wrong extension or a corrupted image.

kbuffington commented 3 years ago

For now you can fix it by replacing 1528 and 1529 with:

if (logo) {
    bandLogo = art_cache.encache(logo, path);
    invertedBandLogo = art_cache.encache(logo.InvertColours(), `${path}-inv`);
}
omercibcp commented 3 years ago

Yup thanks managed to solve the issue.Had one other thing,having a hard time downloading the record label file through git lfs. Is there not an easier way to get it for a noob like myself because when I tried to download it from the image packs on here : https://kbuffington.github.io/Georgia/docs/installation.html it's just a pointer file.Thanks in advance !

kbuffington commented 3 years ago

Thanks for the heads up about the recordlabel.zip file. Somehow even though I took it out of LFS it was still pointing there. All should be good now.

kbuffington commented 3 years ago

Fixed in 2.0.3.