kbumsik / opus-media-recorder

MediaRecorder polyfill for Opus recording using WebAssembly
http://kbumsik.io/opus-media-recorder/
Other
318 stars 39 forks source link

Parameter "TimeSlice" not to spec (seconds instead of milliseconds) #59

Closed NHQ closed 2 years ago

NHQ commented 2 years ago

The spec, and the inline comments of this module, indicate the "timeslice" parameter for the start method should be in milliseconds. This module expects the value in seconds.

Here is line converting timeslice to milliseconds from seconds: https://github.com/kbumsik/opus-media-recorder/blob/master/src/OpusMediaRecorder.js#L362