search

kbuzsaki / bingosync

Collaborative bingo boards for speedrun races
https://bingosync.com
90 stars 108 forks source link

synerGen: minor issues #320

Closed ManicJamie closed 5 months ago

ManicJamie commented 1 year ago

2 of the matrix transformations performed on the base matrix in synerGen are problematic.

inverse(t) doesn't mutate t or return s, hence affecting nothing. As rotate relies on an inverse, this turns rotate into a second reflection. This cuts down the potential magic square permutations eightfold.

kbuzsaki commented 5 months ago

Hey, thanks for flagging the issue! I didn't write the synerGen generator so I'm not familiar with it's implementation. Maybe @asheevee can comment?

I'm also cognizant of the fact that changing a base generator implementation like this can destabilize card generation for all of the communities that are using it (and might e.g. have events in progress) so I'm going to tread carefully when making edits.

asheevee commented 5 months ago

I'll take a look at it! I haven't touched the thing in years it feels like, and it's 100% possible I just forgot a return command somewhere.

kbuzsaki commented 5 months ago

@asheevee's fix is now live :)