search

kbysiec / vscode-search-everywhere

Visual Studio Code extension to easily navigate through files and symbols in the whole workspace.
https://marketplace.visualstudio.com/items?itemName=kbysiec.vscode-search-everywhere
MIT License
60 stars 8 forks source link

Result descriptions are being used for filtering #1

Open russelldavis opened 4 years ago

russelldavis commented 4 years ago

First of all, thanks for this extension! It's exactly what I was looking for.

So the issue is, each result in the list has a description like "Module at line: 1", and those descriptions are being used for filtering. So if I type in "line", I'll get a bunch of results that don't actually have "line" in their name, but they match "line" in the description text.

This also results in even stranger matches due to the fuzzy filtering. If I search for "main", it will show a bunch of arbitrary methods, because it's matching on individual letters, shown in brackets here: "[M]ethod [a]t lines 39 - 44 [in] Foo"

kbysiec commented 4 years ago

Hi! Thank you for this issue. I am very happy the extension is helpful.

The API for quick pick is pretty limited but I will think a little and try to implement some custom filter mechanism next week (currently I do not have access to my computer).

The best option would be to keep the name of the item kind only for information but allow at the same time to narrow the results using filter phrase.

I will do my best to implement something what will fix this problem.

I will keep you informed.

Thanks.

kbysiec commented 4 years ago

Unfortunately, as far as I know, the current API is not sufficient to implement custom filtering ☹️ I will keep it on track and in case anything changes I will come back to the issue and implement some custom filtering logic.