search

kbytesys / django-recaptcha3

Django reCaptcha v3 field/widget
GNU Lesser General Public License v2.1
70 stars 41 forks source link

Adjust recaptcha score threshold #2

Closed mtb-beta closed 5 years ago

mtb-beta commented 5 years ago
mtb-beta commented 5 years ago

Thank you for your reply

Could please use this default value and update the readme.md with the new value?

The score distribution is not clear until reaptcha v3 starts the service. For safe deployment, I think that it is better to first check only the token. I think the default value of django-recaptcha3 should be None. What do you think about this?

kbytesys commented 5 years ago

The score distribution is not clear until reaptcha v3 starts the service. For safe deployment, I think that it is better to first check only the token. I think the default value of django-recaptcha3 should be None. What do you think about this?

We can mix your previous commits with the new one. What do you think if we bring back the idea about to set the default score in the application configuration?

something like this just to be clear:

self._score_threshold = kwargs.pop('score_threshold', settings.RECAPTCHA_SCORE_THRESHOLD)

What do you think?

mtb-beta commented 5 years ago

OK. I think that is all right.

I fixed the code. please confirm.

Thank you.